Ticket #2 (closed defect: fixed)
09-020 CalcEquilibrium input arguments are logged after many intervening calls
Reported by: | michaelhalloran | Owned by: | Michael Halloran |
---|---|---|---|
Priority: | minor | Milestone: | Refactoring |
Component: | COLoggers | Version: | 1.08.3 |
Keywords: | Cc: |
Description
The scenario involves mostly a TP flash with accompanying property calculations. In the log file I have:
PropertyPackage <Anonymous> : Call to CalcEquilibrium requesting a TP flash:
MaterialObject <Anonymous> : Call to GetNumComponents
MaterialObject GetNumComponents returns 2
MaterialObject <Anonymous> : Return from GetNumComponents - No Error
To finally end with:
MaterialObject <Anonymous> : Call to SetProp :
Property Phase--- Basis--- Calc---- New value
volume Liquid mole Mixture 0.000022776
MaterialObject <Anonymous> : Return from SetProp - No Error
PropertyPackage Flashtype: TP
PropertyPackage Properties: enthalpy, volume
PropertyPackage <Anonymous> : Return from CalcEquilibrium - No Error
My point is that the lines:
PropertyPackage Flashtype: TP
PropertyPackage Properties: enthalpy, volume
Appear way too long after stating that a CalcEquilibrium is called. I would prefer, for the readibility of the log to have:
PropertyPackage <Anonymous> : Call to CalcEquilibrium requesting a TP flash:
PropertyPackage Flashtype: TP
PropertyPackage Properties: enthalpy, volume
And then
MaterialObject <Anonymous> : Call to GetNumComponents
MaterialObject GetNumComponents returns 2
MaterialObject <Anonymous> : Return from GetNumComponents - No Error
I have logged this issue as COLTT 09-020.
Attachments
Change History
comment:1 Changed 15 years ago by michaelhalloran
- Status changed from new to closed
- Resolution set to fixed
comment:2 Changed 15 years ago by michelpons
- Status changed from closed to reopened
- Resolution fixed deleted
I have tested the resolution in COLTT 1.08.3 (Build Oct 27, 2009). The log file obtained on Oct 31, 2009 shows:
<Anonymous> : Call to CalcEquilibrium requesting:
Flashtype: TP
Properties: enthalpy, volume
So the flashtype and associated properties are now showing on lines just after the line mentioning the call to CalcEquilibrium. However, for the sake of consistency with other log lines, it should be:
PropertyPackage <Anonymous> : Call to CalcEquilibrium requesting:
Flashtype: TP
Properties: enthalpy, volume
Changed 15 years ago by michelpons
- Attachment gservercorba_103109_105833.log added
Log file obtained with COLTT 1.08.3 Build Oct 27, 2009
comment:3 Changed 15 years ago by michaelhalloran
- Status changed from reopened to closed
- Resolution set to fixed
Loggername is now included in the output.
comment:4 Changed 15 years ago by michelpons
- Version set to 1.08.3
I have re-run the case with COLTT 1.08.4. There is now in the log (see gservercorba_110509_153332.log attached):
PropertyPackage <Anonymous> : Call to CalcEquilibrium requesting:
Flashtype: TP
Properties: enthalpy, volume
MaterialObject <Anonymous> : Call to GetNumComponents
MaterialObject GetNumComponents returns 2
MaterialObject <Anonymous> : Return from GetNumComponents - Succeeded
So the logger name is indeed included in the output. Hence pb fixed.
Changed 15 years ago by michelpons
- Attachment gservercorba_110509_153332.log added
Log file obtained with COLTT 1.08.4
Flashtype and requested Properties are now printed at the beginning of the log of a CalcEquilibrium call.