Ticket #28 (closed defect: fixed)

Opened 2 months ago

Last modified 4 weeks ago

Missing resource version

Reported by: michelpons Owned by: jasper
Priority: major Milestone: 1.1 extension maintenance
Component: PIA 1.1 Version: 2.1.2
Keywords: Cc:

Description

To ensure that Windows Installer properly consider its modifications, PIA 1.1 should display a resource version. It does not. Resource version number should be the same as the version number of the installer used to distribute the PIA file.

Change History

comment:1 Changed 5 weeks ago by jasper

This is a matter of

  • copying and adjusting the resource script from the companion DLL
  • compiling it using the resource compiler, from .rc to .res
  • specifying the .res file on the command line of ilasm: /resource: file.res

(https://docs.microsoft.com/en-us/dotnet/framework/tools/ilasm-exe-il-assembler)

comment:2 Changed 4 weeks ago by jasper

I see that CAPE-OPEN IDL\1-0-0\1-0-0.rc already exists. Updated version number in here. Similarly, CAPE-OPEN IDL\1-1-0\1-1-0.rc already exists. Updated version number in here.

CAPE-OPEN IDL\1-1-0-ext\1-1-0-ext.rc exists, but as this does not actually apply to any dll, it was removed.

Corrected the output paths on the rc files (to prevent incorrect build warning that the res files are not created)

Added the res file to the ilasm command line.

Fixed in revision 127

comment:3 Changed 4 weeks ago by michelpons

  • Milestone set to 1.1 extension maintenance

comment:4 Changed 4 weeks ago by michelpons

Checked with distribution obtained with commit 144 that the PIA files are carrying resource version.

comment:5 Changed 4 weeks ago by michelpons

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.