Ticket #14 (closed enhancement: fixed)
Possible inconsistence in return messages from methods
| Reported by: | michelpons | Owned by: | michaelhalloran |
|---|---|---|---|
| Priority: | major | Milestone: | Refactoring |
| Component: | COLoggers | Version: | 1.08.3 |
| Keywords: | Cc: | michaelhalloran |
Description
I am using as PME-PMC combination UniSim Design (PME) and Simulis Thermodynamics (PMC). In the log obtained with COLTT 1.08.03 enabled on the Simulis Thermodynamics Thermo System, I find the following:
PropertyPackage <Anonymous> : GetComponentList returns :
Name CAS No Formula TBP MW
Nitrogen 7727-37-9 N2 77.3565 28.0134
Argon 7440-37-1 Ar 80.3011 39.948
Oxygen 7782-44-7 O2 90.1792 31.9988
PropertyPackage <Anonymous> : Return from GetComponentList - Succeeded
It is a pattern that mentions \"Succeeded\" on the line corresponding to the return from a method.
But I find also:
PropertyPackage <Anonymous> : Call to GetComponentConstant requesting these constants :
molecularWeight
MaterialObject <Anonymous> : Call to get_ComponentIds
get_ComponentIds returns :
7727-37-9
7440-37-1
7782-44-7
MaterialObject <Anonymous> : Return from get_ComponentIds - Succeeded
PropertyPackage <Anonymous> : GetComponentConstant returns
Compounds molecularWeight
7727-37-9 28.013400
7440-37-1 39.948000
7782-44-7 31.998800
The \"succeeded\" is not mentioned then.
Attachments
Change History
Changed 15 years ago by michelpons
- Attachment unisimdesign_102109_184259.log added
comment:1 Changed 15 years ago by michaelhalloran
- Status changed from new to closed
- Resolution set to fixed
Fixed, found two examples: GetComponentConstant and CreateMaterialObject, both now updated. Fix will be included in builds after 22/10/09
comment:2 Changed 14 years ago by michelpons
I have applied COLTT 1.08.3 Build October 27, 2009 to this combination. In the log obtained (unisimdesign_103109_150608.log), I find now the lines:
PropertyPackage <Anonymous> : Call to GetComponentConstant requesting these constants :
normalBoilingPoint
MaterialObject <Anonymous> : Call to get_ComponentIds
get_ComponentIds returns :
7727-37-9
7440-37-1
7782-44-7
MaterialObject <Anonymous> : Return from get_ComponentIds - Succeeded
PropertyPackage <Anonymous> : GetComponentConstant returns
Compounds normalBoilingPoint
7727-37-9 77.356500
7440-37-1 80.301100
7782-44-7 90.179200
PropertyPackage <Anonymous> : Return from GetComponentConstant - Succeeded
It shows that for GetComponentConstant, a successful outcome is now mentioned properly. I can't tell for CreateMaterialObject from the test case used.
My belief is that this defect may be closed indeed.
Changed 14 years ago by michelpons
- Attachment unisimdesign_103109_150608.log added
Log file obtained with COLTT 1.08.3 Build Oct 27, 2009
Log file obtained with COLTT 1.08.03