Ticket #76 (closed enhancement: fixed)

Opened 18 months ago

Last modified 15 months ago

Short path name in COBIA_INCLUDE environment variable during installation

Reported by: jasper Owned by: jasper
Priority: minor Milestone: Maintenance of Phase II
Component: COBIA SDK MSI Version: 1.2.0.7
Keywords: Cc:

Description (last modified by michelpons) (diff)

In trying to debug the issue reported here:

http://www.cape-open-forum.org/viewtopic.php?t=725&p=2563#p2563

on my own file system I found that the directory I created for the test does not actually have a short equivalent, which according to the documentation of GetShortPathName? is a valid outcome of the function call:

https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getshortpathnamew

This means that the current custom action by the installer will attempt to make a short path name (which in case of the above forum item apparently succeeded, the issue there is another one), and sometimes this will result in a long path name nevertheless.

We could leave as is, and accept that sometimes the path name contains spaces, or remove the attempt to make a short path name altogether, which means the long path name (which will always contain spaces, given the default installation folder) will be used.

Comments?

Change History

comment:1 Changed 18 months ago by michelpons

  • Description modified (diff)

comment:2 Changed 15 months ago by jasper

Decision made in M&T SIG:

  • don't change the COBIA_INCLUDE environment value to be a short path name
  • remove the custom action that does so
  • remove the custom action DLL

Upon delivering a new installer, list this item in release notes.

Visual Studio users will not likely be affected. For other compilers, worst case scenario is that the COBIA_INCLUDE is not supported as it contains spaces and the developer will have to manually provide the right include folder.

comment:3 Changed 15 months ago by jasper

  • Status changed from new to closed
  • Resolution set to fixed

fixed in revision 209

Note: See TracTickets for help on using tickets.