Ticket #179 (closed defect: fixed)

Opened 9 months ago

Last modified 5 months ago

ECapeThrmPropertyNotAvailableHR conversion issues with COMBIA

Reported by: jasper Owned by: jasper
Priority: critical Milestone: Maintenance of Phase II
Component: COMBIA Version: 1.2.0.13
Keywords: Cc:

Description

COMBIA converts a COM ECapeThrmPropertyNotAvailableHR call into containsMissingValues=true; this is not correct according to thermo E&C and COM rules: it should assume the call to fail.

1) does COMBIA subsequently iterate over each of the compound and properties to figure out what is and what is not available?

2) In the opposite direction COMBIA creates the COM output value while raising ECapeThrmPropertyNotAvailableHR which is in conflict with E&C (cannot raise a COM error and return values)

Change History

comment:1 Changed 9 months ago by jasper

Thermo SIG agreement:

1) for a COM PP that returns ECapeThrmPropertyNotAvailableHR COMBIA is to iterate over all compounds and properties in the request, figure out what is missing and return partial resaults properly

2) for a COBIA PP that returns partial results, the COM wrap raises ECapeThrmPropertyNotAvailableHR and no property values are returned

comment:2 Changed 9 months ago by jasper

  • Status changed from new to closed
  • Resolution set to fixed

comment:3 Changed 9 months ago by jasper

In [b53962e6346bbe11da178e6dce57e6e0a062076f]:

fix #179 and marshal DEBUG fixes

comment:4 Changed 5 months ago by jasper

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:5 Changed 5 months ago by jasper

When the COM components return ECapeThermoPropertyUnknownHR, COMBIA reverts to iteration over compounds and properties. The specification variables for a single compound and property are incorrectly filled, causing PMCs to correctly raise an error under these circumstances.

comment:6 Changed 5 months ago by jasper

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in change sets 78cc2d9 and 753e104

Last edited 5 months ago by jasper (previous) (diff)
Note: See TracTickets for help on using tickets.