Ticket #150 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Registry reading on Windows fails to exit loop in case of read error

Reported by: jasper Owned by: jasper
Priority: major Milestone: Maintenance of Phase II
Component: Registry Version: 1.2.0.11
Keywords: Cc:

Description

In case the read loop of the COBIA registry would encounter an error condition in Windows API function ReadFile?, the loop would not exit and the application would hang.

This will not happen under normal conditions, as ReadFile? does not normally fail.

Change History

comment:1 Changed 2 years ago by jasper

  • Status changed from new to closed
  • Resolution set to fixed

comment:2 Changed 2 years ago by michelpons

Could you explain the new logic applied in COBIA/COBIA/Registry.cpp? ReadFile? is made so it returns FALSE if the function fails. What additional logic had to be brought in?

comment:3 Changed 2 years ago by jasper

ReadFile? returns false on an error. In this case the read loop is exited now, which was not the case before.

comment:4 Changed 2 years ago by michelpons

Are we talking of the COBIA registry here? Reference to Windows in the ticket title makes wonder which registry is read here, the Windows registry or the COBIA registry.

comment:5 Changed 2 years ago by jasper

Yes - reading the COBIA registry XML from disk.

Note: See TracTickets for help on using tickets.