Error table in merge modules

[michelpons]

While the build of COBIA version 1.2.0.9 is successful, there is the following warning within the step that builds COBIA_RunTime_Common.msm.
warning LGHT1072 : Merge modules should not contain the 'Error' table because all merge conflicts cannot avoided. However, this warning can be suppressed if all of the consumers of the Merge Module agree to not duplicate identifiers in the 'Error' table.
Is there an agreement by all consumers of the COBIA Runtime merge module to not duplicate identifiers in the Error table? If not could the 'Error' table be suppressed?

[jasper]

Send me the merge module for inspection?

[jasper]

Fixed in commits 269 and 270

[michelpons]

Don't think commits 269 and 270 addressed this ticket since new build made using commits 269 and 270 still leads to:

Building COBIA_RunTime_Common.msm

---

Windows Installer XML Toolset Compiler version 3.11.2.4516
Copyright (c) .NET Foundation and contributors. All rights reserved.

MergeModuleCommon?.wxs
Windows Installer XML Toolset Linker version 3.11.2.4516
Copyright (c) .NET Foundation and contributors. All rights reserved.

C:\agent\_work\66\s\src\ext\UtilExtension?\wixlib\UtilExtension?.wxs(41) : warning LGHT1072 : Merge modules should not contain the 'Error' table because all merge conflicts cannot avoided. However, this warning can be suppressed if all of the consumers of the Merge Module agree to not duplicate identifiers in the 'Error' table.

Merge module being sent.

[jasper]

Indeed - these check-ins solve the versioning issue. Fixing.

[jasper]

Fixed in commits 271 and 272

[jasper]

Suppressing the warning. It originates from changing the access on the COBIA data folder in the common merge module - this is not typically done for merge modules.

[michelpons]

Not fixed when building distribution using commits 271 and 272: 'Error' table still present in COBIA_Runtime_Common.msm.

---

Building COBIA_RunTime_Common.msm

---

Windows Installer XML Toolset Compiler version 3.11.2.4516
Copyright (c) .NET Foundation and contributors. All rights reserved.

MergeModuleCommon?.wxs
light.exe : warning LGHT1098 : 'SuppressSpecificWarnings1072' is not a valid command line argument.
Windows Installer XML Toolset Linker version 3.11.2.4516
Copyright (c) .NET Foundation and contributors. All rights reserved.

C:\agent\_work\66\s\src\ext\UtilExtension?\wixlib\UtilExtension?.wxs(41) : warning LGHT1072 : Merge modules should not contain the 'Error' table because all merge conflicts cannot avoided. However, this warning can be suppressed if all of the consumers of the Merge Module agree to not duplicate identifiers in the 'Error' table.
C:\agent\_work\66\s\src\ext\UtilExtension?\wixlib\UtilExtension?.wxs(42) : warning LGHT1072 : Merge modules should not contain the 'Error' table because all merge conflicts cannot avoided. However, this warning can be suppressed if all of the consumers of the Merge Module agree to not duplicate identifiers in the 'Error' table.
C:\agent\_work\66\s\src\ext\UtilExtension?\wixlib\UtilExtension?.wxs(43) : warning LGHT1072 : Merge modules should not contain the 'Error' table because all merge conflicts cannot avoided. However, this warning can be suppressed if all of the consumers of the Merge Module agree to not duplicate identifiers in the 'Error' table.

Additional new warning appears. See above:
light.exe : warning LGHT1098 : 'SuppressSpecificWarnings1072' is not a valid command line argument.

[jasper]

Additional fix in commits 275, 276.

[michelpons]

Build was not successful after taking into account commits 275, 276:

Build stopped at:

Building COBIA_RunTime_Common.msm

---

Windows Installer XML Toolset Compiler version 3.11.2.4516
Copyright (c) .NET Foundation and contributors. All rights reserved.

MergeModuleCommon?.wxs
light.exe : error LGHT0103 : The system cannot find the file '1072' with type 'Source'.
Traceback (most recent call last):

File "D:\OneDrive?\SOFTWARE\COBIA\BUILD\makedistribution.py", line 460, in <module>

wixbuild('COBIAcommon_Runtime','COBIA_Runtime_Common.msm','x86',MergeModuleCommon?,modules=WixUtilExtension?,linkOptions=['-SuppressSpecificWarnings?','1072'])

File "D:\OneDrive?\SOFTWARE\COBIA\BUILD\makedistribution.py", line 443, in wixbuild

raise RuntimeError?('Job failed:',' '.join(task))

RuntimeError?: ('Job failed:', 'C:
Program Files (x86)
WiX Toolset v3.11
bin
light.exe -out D:
OneDrive?
SOFTWARE
COBIA
COBIA.1.2.0.9
dist
COBIA_Runtime_Common.msm -pdbout D:
OneDrive?
SOFTWARE
COBIA
COBIA.1.2.0.9
dist
COBIA_Runtime_Commonwixpdb -cultures:null D:
OneDrive?
SOFTWARE
COBIA
BUILD
Installer
COBIAcommon_Runtime
obj
x86
Release
MergeModuleCommon?.wixobj -ext C:
Program Files (x86)
WiX Toolset v3.11
bin
WixUtilExtension?.dll -SuppressSpecificWarnings? 1072')

[jasper]

Fixed by commits 277, 278

[jasper]

(sorry about that - third time lucky)